DUI3-426 add offset rotation to the currently applied crs to send receive data #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obj builder); assignment to Sent & Received GIS/nonGIS classes
oguzhankoral
changed the title
…rrently-applied-CRS-to-send-receive-data
KatKatKateryna
added a commit
to specklesystems/speckle-sharp-connectors
that referenced
this pull request
Jul 5, 2024
KatKatKateryna
added a commit
to specklesystems/speckle-sharp-connectors
that referenced
this pull request
Jul 15, 2024
* PR moved from specklesystems/speckle-sharp#3545 * ArcGISDocument to Singleton * read offsets from metadata * move crs assignment on send to RootObjBuilder * move all conversions to activeCRS * safer read from metadata * default degrees to meters (like QGIS) * csharpier * scoped * remove UoW from root builders as send/recieve bindings already use it (#21) * remove POC comment * remove unnecessary assignments; add offsets to incoming dataset name * limit dataset name length * tilt ellipse on receive * fix substrings * remove Rhino uow comment * add SR to the received dataset name * format --------- Co-authored-by: Adam Hathcock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces SpatialReference settings with custom settings (offset, rotation) to be set per Send/Receive operation.
This makes the operation independent on the Map settings, especially if we need to read and apply a Spatial Reference/CRS specified in the received commit. This creates the placeholder to add these custom settings once we have a standardized ProjectInfo property.
TODO: after #3521 is merged, need to check every converter and replace ContextStack Units and SpatialRef data with the "ActiveCRS" data
TODO 2: save offsets on send, and read on receive